Adjust simulation window #143
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #143 +/- ##
===========================================
- Coverage 97.12% 81.05% -16.07%
===========================================
Files 31 31
Lines 938 665 -273
===========================================
- Hits 911 539 -372
- Misses 27 126 +99
Continue to review full report at Codecov.
|
| # So the last initial_params is already a part of the future simulation | ||
| # And we must take the | ||
| # So the last initial_params is already a part of the future simulation. | ||
| # When we simulate 60 steps ahead the last observation is one too much for us. |
There was a problem hiding this comment.
This comment isn't too clear to me, maybe elaborate a bit here? Why 60 steps? What does it mean one too much?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.