Filters options linked with DB and consistent with UserPreferences #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecornamu
approved these changes
May 3, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR closes #176 and #179.
Modifications
FilterScreen takes now 4 new parameters to be consistent with the DiscoveryScreenViewModel. Those are
selectedLevels,setSelectedLevels,selectedActivityTypeandsetSelectedActivityType.FilterScreen does now remember your prefered activity to be shown first, and your level into it! If you change sports, you have
this sport level, (and you can change it).
You have also the checkbox for that activates the option to show only "Known data activities", which is basically enabled and set in the ViewModel.
The PR concerning the filters next week should very much beneficiate from this!