Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only testing PR for the OSM API service #261

Merged
merged 4 commits into from
May 13, 2024
Merged

Only testing PR for the OSM API service #261

merged 4 commits into from
May 13, 2024

Conversation

Andy130604
Copy link
Contributor

No description provided.

@Andy130604 Andy130604 added this to the Milestone 3 milestone May 12, 2024
@Andy130604 Andy130604 self-assigned this May 12, 2024
@JeremyHugentobler JeremyHugentobler self-requested a review May 13, 2024 14:15
JeremyHugentobler
JeremyHugentobler approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@JeremyHugentobler JeremyHugentobler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API testing was still a big missing part of the team's testing capabilities, but this changes everything !

We will definitively follow your work for the next tests we are going to write !

app/.gitignore Outdated
@@ -1,6 +1,7 @@
./idea

/build
/schemas
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

folder generated by Android Rooms and indeed it should not be on the git

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Andy130604 Andy130604 merged commit 773158c into main May 13, 2024
3 checks passed
@Andy130604 Andy130604 deleted the testing/osmapi branch May 13, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeremyHugentobler JeremyHugentobler JeremyHugentobler approved these changes

Assignees

@Andy130604 Andy130604

Labels
None yet
Projects
None yet
Milestone
Milestone 3
Development

Successfully merging this pull request may close these issues.
2 participants
@Andy130604 @JeremyHugentobler