Login Screen - Information about the app

[JeremyHugentobler]

Login Screen - Information about the app

Content

I added a pager in login screen where basic information about the app can be found. All text are translated and all new composable have been tested.

If you want to suggest other content in those pages, you are more than welcome to request changes.

Preview

Dark theme

Normal theme

[Andy130604]

Everything looks fantastic, I love it! I added 2 comments on small changes that would be really nice to have a look at. Otherwise the pager is implemented very neatly and could be reused in other parts of the app I guess.

[ecornamu]

Hello Jérémy, good job improving the app's aspect and the user experience :)
I requested small changes so that you modularizes your code a bit more and change a small nitpick in translations, but in terms of functionality your code seems perfect.

[sonarcloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
77.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[CassioManuguerra]

Hi Jerem,
your PR is really aesthetic, it's feeling super smooth, looking better than ever after the requested changes, and it is a great new feature to our app, crucial for new users. I really like that you tested 100%, nice effort !
You also added comments which is great. Simple yet solid PR, nice job :)

I'm approving, but as a suggestion, you're not forced to change this because it is subjective to what I think personally, I was thinking that "Swipe to learn more..." is not the best way to formulate this first sentence, and I would put something like "New to Lasta ? Swipe to learn more !", "What is Lasta ? Swipe for more info ->", or something similar to this. Let me know what you think about it, and good job once more !

[ecornamu]

Well done my Lord, it's perfect

[Andy130604]

Everything in order on my side! Nice addition and insane testing :)

[JeremyHugentobler]

Hi Jerem, your PR is really aesthetic, it's feeling super smooth, looking better than ever after the requested changes, and it is a great new feature to our app, crucial for new users. I really like that you tested 100%, nice effort ! You also added comments which is great. Simple yet solid PR, nice job :)

I'm approving, but as a suggestion, you're not forced to change this because it is subjective to what I think personally, I was thinking that "Swipe to learn more..." is not the best way to formulate this first sentence, and I would put something like "New to Lasta ? Swipe to learn more !", "What is Lasta ? Swipe for more info ->", or something similar to this. Let me know what you think about it, and good job once more !

Hi Cassio, thanks for your feedback ! This is indeed something that we could discuss all together at the next meeting and can easily be changed later on. For now I think that my version is OK, but if needed we will change that later this week