Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing/profilestats #87

Merged
merged 4 commits into from
Apr 11, 2024
Merged

Testing/profilestats #87

merged 4 commits into from
Apr 11, 2024

Conversation

ecornamu
Copy link
Contributor

Added testing to two folders, mainly :

  • Fully tested data/model/profile folder which amounts to 85% line coverage. The remaining 15% is trivial code such as enums and data classes with no additional functions. I can add test for them if we really seek full coverage but I don't think it is relevant
  • Tested the Activity Converter for a line coverage of 99%, which amounts to 28% of the lines of the data/db folder

@ecornamu ecornamu linked an issue Apr 11, 2024 that may be closed by this pull request
Copy link
Contributor

@npfrei npfrei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, all tests pass

Copy link

sonarcloud bot commented Apr 11, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ecornamu ecornamu merged commit 731588b into main Apr 11, 2024
3 checks passed
@JeremyHugentobler JeremyHugentobler removed their request for review April 11, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test the User Profile Page
2 participants