Combined transverse & longitudinal laser profile #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RemiLehe
changed the title
RemiLehe
changed the title
RemiLehe
changed the title
MaxThevenet
approved these changes
Dec 19, 2022
|
Yes, that's correct, the mathematical expressions are the same as before this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR finalizes the implementation of transverse and longitudinal laser profiles:
A new class
CombinedLongitudinalTransverseProfileis created ; its usage is illustrated in the example.The previously-existing profiles (Gaussian, Hermite-Gauss, Laguerre-Gauss) have been moved to:
In general, it is expected that pulses will be constructed with
CombinedLongitudinalTransverseProfile. However, because the 3D Gaussian pulse is so commonly used, I created a dedicated class for this type of laser ; its usage is illustrated in the example.