Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added segmentation relabeling. #74

Merged
merged 1 commit into from
Aug 23, 2016
Merged

Conversation

twongjirad
Copy link
Member

For issue: #73

@twongjirad twongjirad merged commit a7de871 into develop Aug 23, 2016
@twongjirad
Copy link
Member Author

Basic relabeling map given in example config file: segmentrelabel.cfg.

Also, I took the liberty of making a README file for the ImageMod folder. There are a lot of processors in there. Would be nice to have documentation. Added some basic documentation for new SegmentRelabel module in this README. Would be nice to update this with information for the rest of the modules.

I confirmed this work by simple eye-test. I didn't check accuracy of relabeling.

ORIGINAL LABELS

original_labels

RELABELED

relabeled

@twongjirad twongjirad deleted the feature/tmw_segementrelabel branch August 23, 2016 23:57
@twongjirad
Copy link
Member Author

Sigh. SegFiller module already does this, maybe...

@drinkingkazu
Copy link

SegFiller allows to re-define map on the fly, avoiding to remaking segmentation image.
There are two cases for re-labling segmentation maps imho:
0) Fixing incorrectly labeled segmentation map

  1. Interfacing with outside software (like caffe) and map the larcv segmentation map to theirs

SegFiller is for 1). SegFiller does not store segmentation map because I think it is confusing to have a segmentation label map with values different from what is defined in enum.
I think this module can be useful for 0)?

@drinkingkazu
Copy link

Yeah I just read issue #73 and understood the intention better. Right, this is done in SegFiller...

I wrote it there, but the purpose is because this operation is considered as a part of channeling our segmentation label definition to an outside software (i.e. caffe for instance). So that's why it's not a module. We can change if we want to, though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants