Add functionality for thumb ratings #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 2017, netflix changed it's rating system from stars to thumbs. The objects returned in
getRatingHistorycontain information about whether a rating was made as a star or a thumb rating butsetVideoRatingis not able to set a thumb rating.I added a
setThumbRatingfunction (and endpoint URL) to do just that. In order to avoid duplicate code, I extracted most of the logic into a helper function (__setRating) that is called by bothsetVideoRatingandsetThumbRating. I also noticed, that the setThumbRating endpoint expects a titleId (upper-case i) whereas the setVideoRating endpoint expects a titleid (lower-case i), which is also considered in the code.