Multi cf reader bug fixes #433
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* append : appends deep copies of all arrays from another collection * shallow append : appends shallow copies of all arrays from another collection
Accumulate declared type, provided durring NetCDF definition phase, and compare against the actual type handed to us durring NetCDF write. This is helpful because at definition time we rely on what the user says they will give us later to write. In practice during the write receiving an array of a different type than declared can result in a variety of bad behaviors ranging from uninitialized values in the file to a segfault. Adds a regression test.
starting with the teca_multi_cf_reader io depends on alg. However, alg already depends on io for use of the table reader in teca_tc_wind_radii. This created a linker cycle, this commit resolves it by moving programmable algorithm and reductions into core.
|
split this into a number of smaller PRs, will close now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a number of critical bug fixes developed in conjunction with the multi-files reader