WIP -- generate valid value masks from surface pressure #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This algorithm computes surface pressure from surface temperature, mean sea level pressure and surface elevation using the dry adiabatic lapse rate.
taobrienlbl
reviewed
Aug 20, 2021
| void compute_surface_pressure(size_t n_elem, const num_t *tas, | ||
| const num_t *psl, coord_t *z, num_t *ps) | ||
| { | ||
| num_t cp = 1.0; // kJ/kg.K |
There was a problem hiding this comment.
cp and cv should be in units of J/Kg/K. This would matter for gam since the units cancel, but it does matter for the GAM * zi parts.
I suggest cp=1004. and cv = 718. as the values used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #526