Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storing all messages between actors to csv files #3155

Merged
merged 57 commits into from
May 29, 2021
Merged

Storing all messages between actors to csv files #3155

merged 57 commits into from
May 29, 2021

Conversation

dimaopen
Copy link
Collaborator

@dimaopen dimaopen commented Mar 29, 2021 •
edited by colinsheppard
Loading

This change is Reviewable

@dimaopen
Saving actor messages to csv file
a400580
@dimaopen
IterationStartsMessage and IterationEndsMessage via event stream in o…
8b659d4 
…rder to keep the iteration events in the right files. Closing the writer at postStop.
@dimaopen
Add saving beam actor transitions
91c2790
@dimaopen
triggerId in most of the messages
ff034bf
@dimaopen
Introduced publishMessageFromTo so that messages with sender/receiver…
462e3d9 
… could be published manually
@dimaopen
Fixed wrong number of args in the extractor
e45b4a8
@dimaopen
More triggerId in beam message classes
8588e41
@dimaopen
Increased image limit size for plant uml (puml)
e1df9e9
@dimaopen
Fixed wrong number of args in the extractor
5b294e2
@dimaopen
Created Logging Ask pattern for publishing sender, receiver, payload
df16de3
@dimaopen
Using Logging Ask pattern where possible. Not storing the temp sender…
8a41213 
… messages.
@dimaopen
Added trigger ids to messages at specs
8c3eb5f
@dimaopen
Merge remote-tracking branch 'origin/develop' into do/#3104-actor-mes…
0d4c547 
…sages-logging

# Conflicts:
#	src/main/scala/beam/agentsim/infrastructure/ChargingNetworkManager.scala
#	src/main/scala/beam/sim/vehiclesharing/RepositionManager.scala
@dimaopen
Merge remote-tracking branch 'origin/develop' into do/#3104-actor-mes…
bc1f667 
…sages-logging
@dimaopen
Copy link
Collaborator Author

Test!

@dimaopen
Copy link
Collaborator Author

Test!

1 similar comment
@dimaopen
Copy link
Collaborator Author

Test!

@dimaopen
Copy link
Collaborator Author

dimaopen commented Mar 29, 2021 •
edited
Loading

Please do not review it yet. I'll put the sequence app here.

@dimaopen dimaopen linked an issue Mar 30, 2021 that may be closed by this pull request
How can we create traces from messages within BEAM #3104
Closed
@dimaopen
Copy link
Collaborator Author

Test!

@dimaopen
Copy link
Collaborator Author

If one could review this PR that would be very helpful

dimaopen and others added 13 commits May 4, 2021 17:42
@dimaopen
Documentation of how to capture beam messages improved. Simplified code.
7365d95
@dimaopen
Removed unneeded file
c946b62
@dimaopen
Put pushing the event to the bus before the actual handling of the ev…
edfc950 
…ent which fixes the order of events. Make the state notes hexagonal. Updating the sequence diagrams received with this change. Commented a person sequence diagram.
@dimaopen
Added the commented person sequence diagram as a picture.
854920d
@dimaopen
MessageLogger is created for a single iteration; waiting until it sav…
b7e6207 
…es all the messages.
@dimaopen
Not starting the MessageLogger in case the debug flag is not set.
72f7d8d
@dimaopen
Merge remote-tracking branch 'origin/develop' into do/#3104-actor-mes…
27b8170 
…sages-logging
@dimaopen @JustinPihony
Improve readability
4dd6514 
Co-authored-by: Justin Pihony <justin.pihony@gmail.com>
@dimaopen
Simplified
f5bc956
@dimaopen
Implemented some notes from peer review
2b123fe
@dimaopen
Replaced all the arbitrary constants for triggerId with -1 to indicat…
df6626d 
…e that there's no tirggerId
@dimaopen
Actors extend directly LoggingMessageActor
cba2934
@dimaopen
replaced akka config parameter akka.actor.debug.receive with beam.deb…
ddcdfc1 
…ug.messageLogging
@dimaopen dimaopen self-assigned this May 7, 2021
@dimaopen
Copy link
Collaborator Author

Test now!

@dimaopen
Copy link
Collaborator Author

Test now!

JustinPihony
JustinPihony reviewed May 20, 2021
View reviewed changes
Copy link
Collaborator

@JustinPihony JustinPihony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The single actor needs addressed most - I could be mis-reading it though

src/main/resources/beam-template.conf Outdated Show resolved Hide resolved
src/main/scala/beam/utils/protocolvis/ActorAsState.scala Outdated Show resolved Hide resolved
src/main/scala/beam/utils/protocolvis/ActorAsState.scala Show resolved Hide resolved
docs/messages.rst Outdated Show resolved Hide resolved
docs/messages.rst Outdated Show resolved Hide resolved
dimaopen and others added 4 commits May 24, 2021 18:55
@dimaopen @JustinPihony
Typo fix
cdd30d0 
Co-authored-by: Justin Pihony <justin.pihony@gmail.com>
@dimaopen @JustinPihony
Type fix 2
5917efc 
Co-authored-by: Justin Pihony <justin.pihony@gmail.com>
@dimaopen
Peer review fix
06852bf
@dimaopen
Added validating that the output path is a directory when a directory…
b7e353d 
… is required. Renamed some symbols in order to get the code more clear.
@dimaopen
Copy link
Collaborator Author

Test!

@dimaopen dimaopen merged commit d0d8612 into develop May 29, 2021
@dimaopen dimaopen deleted the do/#3104-actor-messages-logging branch May 29, 2021 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustinPihony JustinPihony JustinPihony approved these changes

@REASY REASY Awaiting requested review from REASY

@wrashid wrashid Awaiting requested review from wrashid

@carloscaldas carloscaldas Awaiting requested review from carloscaldas

Assignees

@dimaopen dimaopen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How can we create traces from messages within BEAM
2 participants
@dimaopen @JustinPihony