Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed not writing rideHailInitialLocation files #3821

Merged
merged 2 commits into from
Feb 7, 2024
Merged

Fixed not writing rideHailInitialLocation files #3821

merged 2 commits into from
Feb 7, 2024

Conversation

dimaopen
Copy link
Collaborator

@dimaopen dimaopen commented Feb 6, 2024 •
edited by beam-bot-new
Loading

  1. Writing happened before actual data is accumulated. That was fixed in this PR.
  2. RHM now writes data in 0.rideHailInitialLocation.name.csv

This change is Reviewable

@dimaopen dimaopen self-assigned this Feb 6, 2024
nikolayilyin
nikolayilyin approved these changes Feb 6, 2024
View reviewed changes
Copy link
Collaborator

@nikolayilyin nikolayilyin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nikolayilyin
Copy link
Collaborator

test!

1 similar comment
@nikolayilyin
Copy link
Collaborator

test!

@dimaopen
Copy link
Collaborator Author

dimaopen commented Feb 7, 2024

test!

@dimaopen dimaopen merged commit e3dd8f3 into develop Feb 7, 2024
1 check passed
@dimaopen dimaopen deleted the do/fix-multiple-rhm-file-writing branch February 7, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikolayilyin nikolayilyin nikolayilyin approved these changes

@haitamlaarabi haitamlaarabi Awaiting requested review from haitamlaarabi

Assignees

@dimaopen dimaopen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dimaopen @nikolayilyin