Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make duplicate reaction test stricter #787

Merged
merged 2 commits into from
May 23, 2023
Merged

Make duplicate reaction test stricter #787

merged 2 commits into from
May 23, 2023

Conversation

stelmo
Copy link
Collaborator

@stelmo stelmo commented May 19, 2023

Takes into account reaction direction now

@stelmo stelmo changed the base branch from master to next May 19, 2023 18:58
@stelmo
Copy link
Collaborator Author

stelmo commented May 19, 2023

/format

triggered by @stelmo on PR #787
@github-actions
Copy link
Contributor

✔️ Auto-formatting triggered by this comment succeeded, commited as cb3449b

@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (3e7ea04) 89.34% compared to head (cb3449b) 89.33%.

Additional details and impacted files
@@            Coverage Diff             @@
##             next     #787      +/-   ##
==========================================
- Coverage   89.34%   89.33%   -0.01%     
==========================================
  Files          92       92              
  Lines        2422     2420       -2     
==========================================
- Hits         2164     2162       -2     
  Misses        258      258              
Impacted Files Coverage Δ
src/utils/Reaction.jl 97.56% <100.00%> (-0.12%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@exaexa exaexa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

(this is the thing that might be eventually moved to fbcmt, right?)

@stelmo
Copy link
Collaborator Author

stelmo commented May 23, 2023

Yep, I will :ax it shortly

@stelmo stelmo merged commit aade5c4 into next May 23, 2023
@stelmo stelmo deleted the sew-duplicate-strict branch May 23, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants