Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more metabolic model tests #19

Merged
merged 12 commits into from
Oct 14, 2022
Merged

Add more metabolic model tests #19

merged 12 commits into from
Oct 14, 2022

Conversation

stelmo
Copy link
Collaborator

@stelmo stelmo commented Oct 14, 2022

Add metabolite tests and neaten the consistency tests

@stelmo stelmo marked this pull request as draft October 14, 2022 08:47
@stelmo stelmo requested a review from exaexa October 14, 2022 08:48
src/memote/consistency.jl Outdated Show resolved Hide resolved
src/memote/metabolites.jl Outdated Show resolved Hide resolved
Copy link
Collaborator

@exaexa exaexa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty much okay, only minor/stylish fixes required.

Regarding the @test infrastructure -- let's not do this in this PR so that we have something working asap; I'll need to solve the test-in-test problem first probably utilizing some kind of dummy AbstractTestSet, then I'll convert it.

src/memote/metabolites.jl Show resolved Hide resolved
src/memote/metabolites.jl Outdated Show resolved Hide resolved
src/memote/metabolites.jl Outdated Show resolved Hide resolved
src/memote/metabolites.jl Outdated Show resolved Hide resolved
src/memote/metabolites.jl Outdated Show resolved Hide resolved
@exaexa
Copy link
Collaborator

exaexa commented Oct 14, 2022

PS please separate all Memote tests into their own PRs. The list here would probably make a good tracking issue.

@stelmo
Copy link
Collaborator Author

stelmo commented Oct 14, 2022

/format

triggered by @stelmo on PR #19
@github-actions
Copy link

✔️ Auto-formatting triggered by this comment succeeded, commited as ea30a31

@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2022

Codecov Report

Base: 33.16% // Head: 47.87% // Increases project coverage by +14.70% 🎉

Coverage data is based on head (1008760) compared to base (652af5e).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 1008760 differs from pull request most recent head ea30a31. Consider uploading reports for the commit ea30a31 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master      #19       +/-   ##
===========================================
+ Coverage   33.16%   47.87%   +14.70%     
===========================================
  Files           3        4        +1     
  Lines         202      259       +57     
===========================================
+ Hits           67      124       +57     
  Misses        135      135               
Impacted Files Coverage Δ
src/memote/consistency.jl 93.90% <100.00%> (ø)
src/memote/metabolites.jl 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@stelmo
Copy link
Collaborator Author

stelmo commented Oct 14, 2022

/format

triggered by @stelmo on PR #19
@github-actions
Copy link

✔️ Auto-formatting triggered by this comment succeeded, commited as 4a74e0c

@stelmo stelmo marked this pull request as ready for review October 14, 2022 15:56
@stelmo stelmo requested a review from exaexa October 14, 2022 15:56
Copy link
Collaborator

@exaexa exaexa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@exaexa exaexa merged commit 8763842 into master Oct 14, 2022
@exaexa exaexa deleted the mo-more branch October 14, 2022 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants