-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more metabolic model tests #19
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty much okay, only minor/stylish fixes required.
Regarding the @test
infrastructure -- let's not do this in this PR so that we have something working asap; I'll need to solve the test-in-test problem first probably utilizing some kind of dummy AbstractTestSet, then I'll convert it.
PS please separate all Memote tests into their own PRs. The list here would probably make a good tracking issue. |
/format |
✔️ Auto-formatting triggered by this comment succeeded, commited as ea30a31 |
Codecov ReportBase: 33.16% // Head: 47.87% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #19 +/- ##
===========================================
+ Coverage 33.16% 47.87% +14.70%
===========================================
Files 3 4 +1
Lines 202 259 +57
===========================================
+ Hits 67 124 +57
Misses 135 135
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
/format |
✔️ Auto-formatting triggered by this comment succeeded, commited as 4a74e0c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Add metabolite tests and neaten the consistency tests