Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add network tests #30

Merged
merged 8 commits into from
Oct 17, 2022
Merged

Add network tests #30

merged 8 commits into from
Oct 17, 2022

Conversation

stelmo
Copy link
Collaborator

@stelmo stelmo commented Oct 16, 2022

No description provided.

@stelmo stelmo requested a review from exaexa October 16, 2022 17:49
@stelmo
Copy link
Collaborator Author

stelmo commented Oct 16, 2022

/format

@github-actions
Copy link

✔️ Auto-formatting triggered by this comment succeeded, commited as 9ea03be

github-actions bot pushed a commit that referenced this pull request Oct 16, 2022
@stelmo
automatic formatting
9ea03be 
triggered by @stelmo on PR #30
@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2022 •
edited
Loading

Codecov Report

Base: 67.69% // Head: 72.13% // Increases project coverage by +4.43% 🎉

Coverage data is based on head (806f6d0) compared to base (666646f).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
+ Coverage   67.69%   72.13%   +4.43%     
==========================================
  Files           8        9       +1     
  Lines         421      488      +67     
==========================================
+ Hits          285      352      +67     
  Misses        136      136
Impacted Files Coverage Δ
src/memote/network.jl 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

exaexa
exaexa reviewed Oct 16, 2022
View reviewed changes
Copy link
Collaborator

@exaexa exaexa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, small things to consider

Project.toml Show resolved Hide resolved
src/memote/network.jl Show resolved Hide resolved
src/memote/network.jl Outdated Show resolved Hide resolved
src/memote/network.jl Show resolved Hide resolved
src/memote/network.jl Show resolved Hide resolved
src/memote/network.jl Show resolved Hide resolved
src/memote/network.jl Show resolved Hide resolved
src/memote/network.jl Show resolved Hide resolved
@stelmo
Copy link
Collaborator Author

stelmo commented Oct 16, 2022

/format

@github-actions
Copy link

✔️ Auto-formatting triggered by this comment succeeded, commited as 83c0182

github-actions bot pushed a commit that referenced this pull request Oct 16, 2022
@stelmo
automatic formatting
83c0182 
triggered by @stelmo on PR #30
@stelmo stelmo requested a review from exaexa October 17, 2022 08:52
exaexa
exaexa requested changes Oct 17, 2022
View reviewed changes
Copy link
Collaborator

@exaexa exaexa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix docs:

┌ Error: no doc found for reference '[`stoichiometric_max_min_value`](@ref)' in src/functions.md.

Otherwise OK

stelmo added a commit that referenced this pull request Oct 17, 2022
@stelmo
automatic formatting
662d5c4 
triggered by @stelmo on PR #30
stelmo added a commit that referenced this pull request Oct 17, 2022
@stelmo
automatic formatting
ce2a8da 
triggered by @stelmo on PR #30
@stelmo
Copy link
Collaborator Author

stelmo commented Oct 17, 2022

/format

@github-actions
Copy link

☀️ Auto-formatting triggered by this comment succeeded, but the code was already formatted correctly.

stelmo and others added 6 commits October 17, 2022 11:21
@stelmo
Copy link
Collaborator Author

stelmo commented Oct 17, 2022

/format

@stelmo stelmo requested a review from exaexa October 17, 2022 09:24
@github-actions
Copy link

☀️ Auto-formatting triggered by this comment succeeded, but the code was already formatted correctly.

@exaexa exaexa mentioned this pull request Oct 17, 2022
Merged
exaexa
exaexa approved these changes Oct 17, 2022
View reviewed changes
Copy link
Collaborator

@exaexa exaexa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ tho.

@exaexa exaexa merged commit 6941e75 into master Oct 17, 2022
@exaexa exaexa deleted the mo-network branch October 17, 2022 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@exaexa exaexa exaexa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stelmo @codecov-commenter @exaexa