added memote consistency tests #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exaexa
requested changes
Oct 26, 2022
stelmo
requested changes
Oct 26, 2022
made the suggested changes to find_disconnected_metabolites
Co-authored-by: Mirek Kratochvil <exa.exa@gmail.com>
changed to use config defaults and isapprox()
use COBREXA constants
added the internal helper function `_compare_flux_bounds` which will be used in `unbounded_flux_in_default_medium`
changed to use the helper function `_compare_flux_bounds`
|
/format |
triggered by @Fl-Sch on PR LCSB-BioCore#50
|
✔️ Auto-formatting triggered by this comment succeeded, commited as 3ccb851 |
|
/format |
triggered by @exaexa on PR LCSB-BioCore#50
|
✔️ Auto-formatting triggered by this comment succeeded, commited as c9940eb |
exaexa
requested changes
Nov 12, 2022
exaexa
reviewed
Nov 12, 2022
Codecov ReportBase: 95.27% // Head: 95.45% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #50 +/- ##
==========================================
+ Coverage 95.27% 95.45% +0.17%
==========================================
Files 16 16
Lines 572 594 +22
==========================================
+ Hits 545 567 +22
Misses 27 27
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
exaexa
approved these changes
Nov 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added the metabolite connectivity and unbounded flux in default medium tests. We are not sure about the structural elements, like if we correctly added to the consistency config.