Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve to readme for the MEMOTE additions #71

Merged
merged 3 commits into from
May 17, 2023
Merged

Conversation

stelmo
Copy link
Collaborator

@stelmo stelmo commented May 15, 2023

No description provided.

@stelmo stelmo requested a review from exaexa May 15, 2023 08:21
@stelmo
Copy link
Collaborator Author

stelmo commented May 15, 2023

/format

@github-actions
Copy link

✔️ Auto-formatting triggered by this comment succeeded, commited as ab6bdad

github-actions bot pushed a commit that referenced this pull request May 15, 2023
triggered by @stelmo on PR #71
Copy link
Collaborator

@exaexa exaexa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gurobi can't be default + a few comments

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
bin/fbcmt-memote-run Outdated Show resolved Hide resolved
bin/fbcmt-memote-report Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
src/memote/frontend.jl Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented May 16, 2023

Codecov Report

Patch coverage: 85.71% and project coverage change: -14.66 ⚠️

Comparison is base (c11ca82) 95.05% compared to head (7cea182) 80.40%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master      #71       +/-   ##
===========================================
- Coverage   95.05%   80.40%   -14.66%     
===========================================
  Files          16       20        +4     
  Lines         607      592       -15     
===========================================
- Hits          577      476      -101     
- Misses         30      116       +86     
Impacted Files Coverage Δ
src/memote.jl 100.00% <ø> (ø)
src/memote/checks/Energy.jl 0.00% <ø> (-89.48%) ⬇️
src/memote/frontend.jl 71.42% <71.89%> (-10.11%) ⬇️
src/memote/utils.jl 50.00% <85.71%> (-50.00%) ⬇️
src/memote/checks/Reactions.jl 95.83% <95.83%> (ø)
src/memote/checks/Annotation.jl 100.00% <100.00%> (ø)
src/memote/checks/Basic.jl 100.00% <100.00%> (ø)
src/memote/checks/Biomass.jl 100.00% <100.00%> (ø)
src/memote/checks/Consistency.jl 100.00% <100.00%> (ø)
src/memote/checks/GPRAssociation.jl 100.00% <100.00%> (ø)
... and 3 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@stelmo
Copy link
Collaborator Author

stelmo commented May 16, 2023

/format

@github-actions
Copy link

✔️ Auto-formatting triggered by this comment succeeded, commited as 08107ef

github-actions bot pushed a commit that referenced this pull request May 16, 2023
triggered by @stelmo on PR #71
@stelmo stelmo requested a review from exaexa May 16, 2023 12:44
Copy link
Collaborator

@exaexa exaexa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess all OK

@exaexa exaexa merged commit 0ec9418 into master May 17, 2023
@exaexa exaexa deleted the sew-readme-memote branch May 17, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants