Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: Add docker creation #178

Merged
merged 23 commits into from
Mar 25, 2021
Merged

feature: Add docker creation #178

merged 23 commits into from
Mar 25, 2021

Conversation

laurentheirendt
Copy link
Member

this should work 😄

repo needs to be bumped and tagged

exaexa
exaexa reviewed Mar 22, 2021
View reviewed changes
Copy link
Collaborator

@exaexa exaexa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: it might be useful to squash the commits

Dockerfile Outdated Show resolved Hide resolved
exaexa
exaexa approved these changes Mar 25, 2021
View reviewed changes
Copy link
Collaborator

@exaexa exaexa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOVELY.

@exaexa exaexa merged commit 73a0729 into develop Mar 25, 2021
@exaexa exaexa deleted the add-docker-creation branch March 25, 2021 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@exaexa exaexa exaexa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@laurentheirendt @exaexa