Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create common action base class, implement reloading #6

Merged
merged 2 commits into from
Oct 11, 2023

Conversation

Ethaks
Copy link
Contributor

@Ethaks Ethaks commented Oct 11, 2023

This PR includes a refactor of actions, introducing a common OuterHeavenAction class providing a common API base to be extended by specific actions. The attack action is accordingly refactored, and a reload action is added. The base class can be further enhanced to handle any future operations meant to be common across multiple action types.

It also includes changes to styles, structuring them to be a bit more generic for general chat message usage.

Additionally, the appearance of the weapons list in the inventory is changed to make use of Foundry's ubiquitous flex styling. A grid based styling would also be possible (and likely even cleaner), although the flex one usually ends up being the most module-friendly of the bunch as modules are free to individually adjust the rendered content.
If the change is deemed worthwhile, it could be expanded to the other item categories, too.

@LDMonay LDMonay merged commit 4518972 into LDMonay:main Oct 11, 2023
1 check passed
@Ethaks Ethaks deleted the actions branch October 11, 2023 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants