feat: create common action base class, implement reloading #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a refactor of actions, introducing a common
OuterHeavenAction
class providing a common API base to be extended by specific actions. The attack action is accordingly refactored, and a reload action is added. The base class can be further enhanced to handle any future operations meant to be common across multiple action types.It also includes changes to styles, structuring them to be a bit more generic for general chat message usage.
Additionally, the appearance of the weapons list in the inventory is changed to make use of Foundry's ubiquitous
flex
styling. Agrid
based styling would also be possible (and likely even cleaner), although theflex
one usually ends up being the most module-friendly of the bunch as modules are free to individually adjust the rendered content.If the change is deemed worthwhile, it could be expanded to the other item categories, too.