Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workaround for #80, no good general solution found so fare #85

Merged
merged 1 commit into from
Nov 9, 2017
Merged

Workaround for #80, no good general solution found so fare #85

merged 1 commit into from
Nov 9, 2017

Conversation

LEDfan
Copy link
Owner

@LEDfan LEDfan commented Nov 6, 2017

No description provided.

@LEDfan
Workaround for #80, no good general solution found so fare
da72585 
Signed-off-by: Tobia De Koninck <tobia@ledfan.be>
@LEDfan LEDfan added the bug label Nov 6, 2017
@LEDfan LEDfan added this to the 1.1.0 milestone Nov 6, 2017
RobinJadoul
RobinJadoul approved these changes Nov 9, 2017
View reviewed changes
Copy link
Collaborator

@RobinJadoul RobinJadoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, not optimal, but what can you do...
Maybe we can move this to some rule based mechanism later on? (such as an easy to configure hacks.js file or the like)

@LEDfan LEDfan mentioned this pull request Nov 9, 2017
Closed
@LEDfan LEDfan merged commit 9e24270 into master Nov 9, 2017
@LEDfan LEDfan deleted the workaround_for_80 branch November 9, 2017 12:34
@LEDfan LEDfan mentioned this pull request Nov 23, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobinJadoul RobinJadoul RobinJadoul approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@LEDfan @RobinJadoul