This repository has been archived by the owner on Oct 2, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far we did not use the accept method of the visitor design pattern in the child classes of the visitor (i.e interpreterVisitor)
It was because we had to use the children AST classes, written in the visitor.ts file, but those classes had a problem dealing with the "Abstract" AST nodes ("Expression", "RobotSymbol" and "Statement").
It was impossible to extend them, given that they are not generated as Interfaces from the current grammar.
In these modifications, we provide a modified version of the ast.ts file, that represents those abstract nodes as Interfaces.
It allow to correctly use the visitor design pattern in its child classes, and so, have a better code.
The best solution is still to modify the grammar, but given the remaining time, I think it is an acceptable solution.
It only requires to use a slightly modified version of the ast.ts file.