Drop daemonizing logic #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, Hugo. As mentioned in #182, could you maybe also delete the |
WhyNotHugo
force-pushed
the
main
branch
4 times, most recently
from
a0dd6ee
to
9b0a455
Compare
WhyNotHugo
commented
Jun 7, 2024
LGFae
reviewed
Jun 7, 2024
Rely on `swww-daemon` instead. It runs in foreground, which is what service managers expect. Usages like running `exec swww` in sway's config continue to work fine. User session start-up scripts can simply run `swww-daemon &`. Fixes: LGFae#182
|
From what I can tell, this looks done. Are you planning on doing anything else? |
|
No, I think this patch is ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run in foreground, which is what service managers expect. Usages like running
exec swwwin sway's config continue to work fine. User session start-up scripts can simply runswww &.Fixes: #182