Zero copy serialization #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LGFae
force-pushed
the
zero-copy-serialization
branch
from
f6f966f
to
5049a20
Compare
This avoid an extra copy, where we were first putting everything in a large vector, then serializing those into bytes, THEN mapping that to the file. Now, the ImageRequestBuilder will by itself already write the image requests to the mmapped file. The code has gotten unruly, we should do some refactoring later.
Things were getting way too chaotic. Now we have multiple smaller files, each roughly concerned with a different problem.
LGFae
force-pushed
the
zero-copy-serialization
branch
from
33cb0e1
to
a15025d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By mmaping the relevant bytes at the correct offsets, we don't need to copy any
strorBoxed<[u8]>.Furthermore, we can serialize directly onto the memory mapped file, thus not needing to copy onto an intermediate buffer first.