Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing product with ID 88 #9

Closed
wborn opened this issue Oct 20, 2020 · 6 comments · Fixed by #10
Closed

Missing product with ID 88 #9

wborn opened this issue Oct 20, 2020 · 6 comments · Fixed by #10

Comments

@wborn
Copy link

wborn commented Oct 20, 2020

Is there a product with ID 88 missing? A user in our community posted there was a light with that product ID which wasn't properly recognized. It looks similar to a LIFX Mini White.

@delfick
Copy link
Contributor

delfick commented Oct 20, 2020

oops. That'll be the Mini we sold for Amazon Prime day. I'll make time this morning to work out if there's anything else we're missing and make sure the json is up-to-date. Thanks for pointing this out!

@delfick
Copy link
Contributor

delfick commented Oct 21, 2020

I have updated the registry. What I learnt today is we need to change our process a little on keeping this up to date. Thanks again for pointing out we were missing a product!

@wborn
Copy link
Author

wborn commented Oct 21, 2020

Thanks a lot for the update! Seems there are quite a few new products. 👍

Do you also know the reason why some products are exactly the same except for their PID?
Is that because they are using different hardware components?

E.g. these product pairs have equal properties except for their PID: 36/37, 87/88, 91/92

@delfick
Copy link
Contributor

delfick commented Oct 21, 2020

Some are because of slight hardware differences and some are because they are for different regions. In all these cases there is no user visible difference.

@wborn
Copy link
Author

wborn commented Oct 21, 2020

Thanks for your help! Now I know everything. 😉

@delfick
Copy link
Contributor

delfick commented Oct 21, 2020

heheh, you're welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants