Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

develop - risks cartography is not correctly shown, when frontend is connected to the backend #192

Closed
kosmas58 opened this issue Apr 5, 2018 · 3 comments
Assignees

Comments

@kosmas58
Copy link
Contributor

kosmas58 commented Apr 5, 2018

connected

Only the background is shown, no bubbles, no arrows and no riskXLetters are shown. This problem occurs everytime you're connected to the backend, no matter

  1. when starting the frontend locally with yarn or npm start

  2. or generating pia-app out of the source with option build --prod --build-optimizer --sourcemaps

  3. or generating the frontend in prod mode in a docker container and so on ...

When not connected to the backend risk mapping is shown in all cases.

not connected

I've used your actual develop version from GitHub.

In your version the arrows are only weakly displayed. I've changed this in risks-cartography.component.ts to:
// Dotted lines params
context.setLineDash([2, 2]);
context.lineWidth = 2;
in my develop version. That leads to better visibility.

improved

@kosmas58 kosmas58 changed the title develop: risks cartography is not correctly shown, when frontend is connected to the backend. develop - risks cartography is not correctly shown, when frontend is connected to the backend. Apr 5, 2018
@kosmas58 kosmas58 changed the title develop - risks cartography is not correctly shown, when frontend is connected to the backend. develop - risks cartography is not correctly shown, when frontend is connected to the backend Apr 5, 2018
@brunto brunto self-assigned this Apr 18, 2018
@brunto brunto added the bug label Apr 18, 2018
@brunto
Copy link
Collaborator

brunto commented Apr 18, 2018

Hello,
I'll review this soon.

@kevin-atnos
Copy link
Collaborator

Hello,

We will try to fix it in the next release (beginning of september 2018). If not, it will be fixed in the next release.

Thank you.

@brunto
Copy link
Collaborator

brunto commented Aug 21, 2018

This is fixed on the master branch of pia-back and pia.
This will be released in the next version 1.6.4

@brunto brunto closed this as completed Aug 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants