Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 32bit compilation #1

Merged
merged 1 commit into from
Aug 23, 2022
Merged

Conversation

delta1
Copy link

@delta1 delta1 commented Aug 22, 2022

Hi @LLFourn

I'm updating some dependencies in xmr-btc-swap and found that the armv7 target needed this for this crate to compile

Tested with

cargo build --target armv7-unknown-linux-gnueabihf

Thanks!

@LLFourn
Copy link
Owner

LLFourn commented Aug 23, 2022

Thanks @delta1! LGTM and I will include it in next release coming soon. Can we make sure secp256kfun compiles to that platform in ci? CI PR for that would be appreciated.

@LLFourn LLFourn closed this Aug 23, 2022
@LLFourn LLFourn reopened this Aug 23, 2022
@LLFourn LLFourn merged commit 39d59c3 into LLFourn:secp256kfun Aug 23, 2022
@delta1
Copy link
Author

delta1 commented Aug 23, 2022

Sure, sounds good!

@delta1
Copy link
Author

delta1 commented Aug 31, 2022

Hi @LLFourn - any ETA on a release for this crate please?

@LLFourn
Copy link
Owner

LLFourn commented Sep 5, 2022

Hi @delta1. Just got back from holiday. I'll make a minor release now.

@LLFourn
Copy link
Owner

LLFourn commented Sep 5, 2022

I've released v2.0.1 of this crate. Turned out I never even pushed the 2.0.0 release commit but I merged your changes in and released the new one. I think I'm going to just vendor this inside secp256kfun to avoid the maintenance burden. The idea to compare against upstream was nice but you can always just diff the directories.

@delta1
Copy link
Author

delta1 commented Sep 5, 2022

Thanks so much! Welcome back 😄 Yeah that definitely sounds easier wrt maintenance 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants