remove attributedict, confusing and offers no benefit #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dawson6
approved these changes
May 10, 2022
white238
approved these changes
May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AttributeDict from
ats/attributedict.pyis a thin wrapper around a plain dictionary. The only "feature" it provides is allowing devs to update its contents like this:my_dict.new_thing = "fancy"in addition to the standardmy_dict["new_thing"] = "fancy"approach that contains no surprises.For this "extra" behavior we would want to use a
@propertywithin aclassto facilitate some additional work. But given that no extra work is done when updating contents of an AttributeDict it seems more appropriate to simply call it what it is, a dictionary.This also greatly improves readability and will allow for an easier update to ATS when integrating Flux into its core.