Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support half with MPI #172

Merged
merged 2 commits into from
Feb 1, 2023
Merged

Support half with MPI #172

merged 2 commits into from
Feb 1, 2023

Conversation

ndryden
Copy link
Collaborator

@ndryden ndryden commented Feb 1, 2023

This adds support for half to the MPI and Host-Transfer backends, and support for testing half datatypes across all backends.

Note that CPU-side half computations are emulated with fp32. They are therefore slower and may not round in the same way as performing native fp16 operations.

This requires half support to be provided. Currently this is via either the HIP/ROCm or CUDA support. In the future we may support other sources for half.

Closes #171. Closes #104.

This adds support for half to the MPI and Host-Transfer backends, and
support for testing half datatypes across all backends.
@ndryden ndryden added the enhancement New feature or request label Feb 1, 2023
@ndryden ndryden requested a review from benson31 February 1, 2023 17:14
Copy link
Collaborator

@benson31 benson31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good.

src/mpi_impl.cpp Show resolved Hide resolved
@ndryden ndryden merged commit 70e283e into master Feb 1, 2023
@ndryden ndryden deleted the mpi-half branch February 1, 2023 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support half in MPI and Host-Transfer Testing half
2 participants