Type traits #206
Merged
Type traits #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benson31
approved these changes
Jul 27, 2023
- Removed `AlBackendName` from op_dispatcher.h that I forgot to remove and updated uses. - Moved some algorithm description into a separate file to cut down on circular includes.
|
@benson31 Rerequesting review because I moved some more stuff around. |
benson31
reviewed
Aug 1, 2023
Comment on lines
+204
to
+209
| #ifdef AL_HAS_HALF | ||
| template <> struct IsTypeSupportedByMPI<__half> : std::true_type {}; | ||
| #endif | ||
| #ifdef AL_HAS_BFLOAT | ||
| template <> struct IsTypeSupportedByMPI<al_bfloat16> : std::true_type {}; | ||
| #endif |
There was a problem hiding this comment.
Is this true? There's no MPI_Datatype value for these types and one cannot, say, MPI_Reduce with them (correctly) without a custom reduction function, so it seems to me that either these should be std::false_type or the documentation should be clarified as to what "supported specifically by MPI itself" means.
There was a problem hiding this comment.
Good point. I'll clarify the documentation that these are supported via Aluminum magic. (Specifically: The TypeMap that everything uses will map them to a dummy datatype, and a custom reduction operator will be used.)
benson31
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exposes type traits describing Aluminum communication operations. Previously they were in the test utilities and not so well-organized.