Improve progress engine binding #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benson31
approved these changes
Nov 3, 2020
|
We can track the improved AMD support in #85. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #82.
Closes #45. Closes #64.
When using CUDA, this should now automatically detect cores close to the GPU device being used. Otherwise this uses similar behavior as before to identify the NUMA node.
(If you've built Aluminum with CUDA support but for some reason are not wanting to use CUDA, there isn't a good way to identify that, and we don't handle that case.)
This should result in more reliable progress engine binding without needing to mess with the
AL_PROGRESS_COREorAL_PROGRESS_RANKS_PER_NUMA_NODEenvironment variables (which no longer do anything).