Fix occupancy calculator and Use common types #1524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in hip/cuda kernel and occupancy calculator functions
add documentation for grid forall policies
rhornung67
reviewed
Aug 3, 2023
| scan, in a GPU kernel launched | ||
| sort with given thread-block | ||
| size. Note that the | ||
| scan, directly mapped to global threads |
There was a problem hiding this comment.
👍 I wish there were a good way to embedd a summary in a rst table so that we don't have to repeat the same description for multiple policies. Oh well.
|
On another note this and some other work brought up is thread safety which I've added an issue for #1525. I did fix this for the occupancy calculator functions in this PR. But we do have a general problem with reducers and memory pools when we configure without OpenMP support. |
rhornung67
reviewed
Aug 3, 2023
| int max_blocks; | ||
| int max_threads; | ||
| }; | ||
|
|
||
| template < typename RAJA_UNUSED_ARG(UniqueMarker), typename Func > | ||
| RAJA_INLINE | ||
| void cuda_occupancy_max_blocks_threads(Func&& func, int shmem_size, | ||
| size_t &max_blocks, size_t &max_threads) | ||
| void cuda_occupancy_max_blocks_threads(Func&& func, size_t shmem_size, |
There was a problem hiding this comment.
We should document conventions like this in the RAJA Dev Guide so we can try to keep type usage consistent during code reviews.
rhornung67
approved these changes
Aug 3, 2023
artv3
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix the compilation of the occupancy calculator and Use common types between the hip and cuda backends in the occupancy calculator and kernel policies and kernel launch helper routines.