Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Woptim] draft filter fix #1609

Merged
merged 7 commits into from
Mar 12, 2024
Merged

[Woptim] draft filter fix #1609

merged 7 commits into from
Mar 12, 2024

Conversation

adrienbernede
Copy link
Member

@adrienbernede adrienbernede commented Mar 4, 2024

Summary

A branch pointing at RADIUSS Shared CI with fixes for the Draft PR filter.

  • Fixes persistent failure of PRs initially marked as draft.
  • Fixes release branches seen as draft because the tag is used instead of the branch name

@adrienbernede adrienbernede changed the title Woptim/draft filter fix [Woptim] draft filter fix Mar 4, 2024
Copy link
Member

@rhornung67 rhornung67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adrienbernede do we want to merge this or wait for a new release of radiuss-shared-ci?

@adrienbernede
Copy link
Member Author

adrienbernede commented Mar 4, 2024

Marked the PR as [WIP]. I’d like to run some more tests.

@adrienbernede adrienbernede changed the title [Woptim] draft filter fix [Woptim] [WIP] draft filter fix Mar 5, 2024
@adrienbernede
Copy link
Member Author

Above failure is proof that I can reproduce the behavior seen during release.

This reverts commit 66c7ad4.
@adrienbernede adrienbernede changed the title [Woptim] [WIP] draft filter fix [Woptim] draft filter fix Mar 11, 2024
@adrienbernede adrienbernede merged commit dcaba9e into develop Mar 12, 2024
24 checks passed
@adrienbernede adrienbernede deleted the woptim/draft-filter-fix branch March 12, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants