Add MultiReducer #1665

MrBurmark · 2024-06-10T23:24:18Z

Add runtime sized reducer

Add a runtime sized reducer based on design mentioned in #1648.

This PR is a feature
It does the following:
- Adds MultiReducer at the request of myself and others
TODO
- testing for random bin per iterate
- testing for all bins per iterate
- testing for some bins per iterate
- testing for cuda/hip that would go over available shmem
- testing with forall
- testing with kernel
- testing with launch
- cuda/hip tuning parameters
- cuda/hip tuning
- fallback for cuda/hip if shmem unavailable
- Figure out nvcc compile issue
- Figure out intel correctness problem with omp::Auto
- omp_target implementation
- sycl implementation
- new reducer interface

this has to do with using HighAccuracyReduce

the reset test will fail because forone does not handle reducers properly

artv3 · 2024-06-11T13:38:16Z

Adding an example could be really nice too! You can probably just take one from the unit test.

MrBurmark · 2024-06-11T16:17:56Z

Here is the nvcc error output.

.../RAJA/test/functional/forall/multi-reduce-basic/tests/test-forall-basic-MultiReduce.hpp:94:394: error: '__T6' was not declared in this scope
     RAJA::forall<EXEC_POLICY>(seg, [=] RAJA_HOST_DEVICE(IDX_TYPE idx) {
                                                                                                                                                                                                                                                                                                                                                                                                          ^

This requires a change in camp to allow use of std::tuple_size before c++17

include/RAJA/policy/hip/policy.hpp

include/RAJA/util/RepeatView.hpp

rhornung67

Overall, looks really good. I had some question comments about a few things and a number of suggestions to clarify documentation.

Co-authored-by: Rich Hornung <hornung1@llnl.gov>

include/RAJA/policy/cuda/policy.hpp

docs/sphinx/user_guide/feature/policies.rst

…nto feature/burmark1/multireduce

rhornung67 · 2024-07-11T17:34:47Z

@MrBurmark third time is the charm? 😄

MrBurmark · 2024-07-11T17:48:45Z

@MrBurmark third time is the charm? 😄

*crosses fingers*

docs/sphinx/user_guide/cook_book/multi-reduction.rst

docs/sphinx/user_guide/feature/multi-reduction.rst

rhornung67 · 2024-07-11T21:19:46Z

docs/sphinx/user_guide/cook_book/multi-reduction.rst

+  // using multi_reduce_policy = RAJA::cuda_multi_reduce_atomic;
+  // using multi_reduce_policy = RAJA::hip_multi_reduce_atomic;
+
+Here a simple sum multi-reduction is performed using RAJA::


I don't think we want that change unless you change: "Here a" to "Here is a", which is more verbose.

include/RAJA/policy/cuda/MemUtils_CUDA.hpp

include/RAJA/policy/cuda/multi_reduce.hpp

Co-authored-by: Robert Chen <chen59@llnl.gov>

…nto feature/burmark1/multireduce

…multireduce

MrBurmark added 18 commits May 21, 2024 10:08

Add Seq and OMP MultiReduce and unit test

195d506

Add reset tests for single and container init versions of reset

25fe448

test resizing on reset

aaa6661

Add basic functional tests

47a0fb8

Add consistency test to reducer tests

2565b68

Align data to avoid false sharing in OMP MultiReducers

988b6d1

Update consistency to also take policy into consideration

fb19038

add ordered/unordered into cuda/hip reduce policies

35094bd

Use get in multi_reduce reference

2453643

Use HighAccuracyReduce in MultiReduceOrderedDataOMP

18c0ef3

Take dynamic_smem by reference in make_launch_body

01cf2bd

Fix typo in MultiReduceOrderedDataOMP

515126f

this has to do with using HighAccuracyReduce

use multi_reduce reference get

40e3e50

Use atomic multi_reduce policies

469ccd6

Fix unit tests for reference get

b1dc681

fixup MemUtils_HIP

37b7f0a

Add host device to BaseMultiReduce*

4b3bb46

Add initial cuda/hip multi reduce impl

77ecd00

the reset test will fail because forone does not handle reducers properly

MrBurmark marked this pull request as draft June 10, 2024 23:24

MrBurmark added 2 commits June 11, 2024 09:13

work around non-working camp type_trait

27f8fc6

Add example of forall and multi_reduce

9b668dc

MrBurmark and others added 7 commits June 11, 2024 10:07

Add for_each_tuple to iterate over elements of tuple

3c41391

This requires a change in camp to allow use of std::tuple_size before c++17

remove extra includes in cuda/hip multi_reduce

3fb0a7d

Add missing include in openmp multi_reduce

cc6ae7a

Use for_each_tuple in forall multi-reduce example

45fc6ad

Make MultiReduce example more interesting

6ea3156

Merge branch 'develop' into feature/burmark1/multireduce

bec1924

Update camp version to support std::tuple_size

fe33670

rhornung67 reviewed Jul 10, 2024

View reviewed changes

include/RAJA/policy/hip/policy.hpp Outdated Show resolved Hide resolved

rhornung67 reviewed Jul 10, 2024

View reviewed changes

include/RAJA/util/RepeatView.hpp Show resolved Hide resolved

rhornung67 approved these changes Jul 10, 2024

View reviewed changes

MrBurmark and others added 2 commits July 10, 2024 14:52

Apply suggestions for documentation from code review

9c52b63

Co-authored-by: Rich Hornung <hornung1@llnl.gov>

Apply suggestions to comments from code review

cd95bb5

Co-authored-by: Rich Hornung <hornung1@llnl.gov>

MrBurmark commented Jul 10, 2024

View reviewed changes

include/RAJA/policy/cuda/policy.hpp Outdated Show resolved Hide resolved

Apply suggestions to comments

f27b772

MrBurmark commented Jul 10, 2024

View reviewed changes

docs/sphinx/user_guide/feature/policies.rst Outdated Show resolved Hide resolved

MrBurmark and others added 7 commits July 10, 2024 16:42

Document fallback when shmem unavailable

c778aca

Add func to Cuda/HipInfo to get right maxDynamicShmem

232df8a

Merge branch 'feature/burmark1/multireduce' of github.com:LLNL/RAJA i…

4485337

…nto feature/burmark1/multireduce

Note issue with setting up shmem and launch dims in kernel

142dfc5

Move Scoped Assignment into utils

a3f8721

fix compile

3d49289

fix fix compile

9264742

fix fix fix compile

361b37f

rchen20 reviewed Jul 11, 2024

View reviewed changes

docs/sphinx/user_guide/cook_book/multi-reduction.rst Outdated Show resolved Hide resolved

rchen20 reviewed Jul 11, 2024

View reviewed changes

docs/sphinx/user_guide/feature/multi-reduction.rst Outdated Show resolved Hide resolved

rhornung67 reviewed Jul 11, 2024

View reviewed changes

rchen20 reviewed Jul 11, 2024

View reviewed changes

include/RAJA/policy/cuda/MemUtils_CUDA.hpp Show resolved Hide resolved

rchen20 reviewed Jul 11, 2024

View reviewed changes

include/RAJA/policy/cuda/multi_reduce.hpp Show resolved Hide resolved

Apply suggestions from code review

84a70f2

Co-authored-by: Robert Chen <chen59@llnl.gov>

rchen20 approved these changes Jul 12, 2024

View reviewed changes

MrBurmark added 3 commits July 12, 2024 10:35

Change radius-spack-configs

893246a

Merge branch 'feature/burmark1/multireduce' of github.com:LLNL/RAJA i…

3970beb

…nto feature/burmark1/multireduce

Merge branch 'develop' of github.com:LLNL/RAJA into feature/burmark1/…

758d065

…multireduce

MrBurmark merged commit c1cffa9 into develop Jul 12, 2024
18 checks passed

MrBurmark deleted the feature/burmark1/multireduce branch July 12, 2024 19:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add MultiReducer #1665

Add MultiReducer #1665

MrBurmark commented Jun 10, 2024 •

edited

Loading

artv3 commented Jun 11, 2024

MrBurmark commented Jun 11, 2024

rhornung67 left a comment

rhornung67 commented Jul 11, 2024

MrBurmark commented Jul 11, 2024 •

edited

Loading

rhornung67 Jul 11, 2024 •

edited

Loading

Add MultiReducer #1665

Add MultiReducer #1665

Conversation

MrBurmark commented Jun 10, 2024 • edited Loading

Add runtime sized reducer

artv3 commented Jun 11, 2024

MrBurmark commented Jun 11, 2024

rhornung67 left a comment

Choose a reason for hiding this comment

rhornung67 commented Jul 11, 2024

MrBurmark commented Jul 11, 2024 • edited Loading

rhornung67 Jul 11, 2024 • edited Loading

Choose a reason for hiding this comment

MrBurmark commented Jun 10, 2024 •

edited

Loading

MrBurmark commented Jul 11, 2024 •

edited

Loading

rhornung67 Jul 11, 2024 •

edited

Loading