Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a text queue to be able to ignore unexpected gdb output; handle r… #32

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

johnlvogt
Copy link
Contributor

The previous version just read output from gdb from a stream, but this proved brittle because if gdb produced extra output, gdb.py would return the result from the previous command for every ensuing command. This version reads the gdb output on a separate thread which keeps it from blocking if the gdb doesn't produce output when expected, and also allows each operation to flush any unprocessed output from the previous command.

There is also a section of changes related to rocgdb specific changes in the format for thread info.

@codecov-commenter
Copy link

Codecov Report

Merging #32 (17c82e8) into develop (445537f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop      #32   +/-   ##
========================================
  Coverage    44.50%   44.50%           
========================================
  Files           10       10           
  Lines         6465     6465           
========================================
  Hits          2877     2877           
  Misses        3588     3588           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 445537f...17c82e8. Read the comment docs.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 642

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 32.468%

Totals Coverage Status
Change from base Build 639: 0.0%
Covered Lines: 3378
Relevant Lines: 10404

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants