Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #221
Fixes poorly designed freeing of file scope gloabls. Thanks to Dave Bremer.
While doing some testing, I found a memory error in DBClose(). I made a patch and wanted to offer it for inclusion in the Silo source. It's a two-line change, so I could hand it to you directly, or submit it through GitHub.
Current code:
Proposed change:
The dbfile->pub.close() function tends to call free on dbfile, so the pointer at dbfile->pub.file_scope_globals is in freed memory. It tends to work, unless you use a Windows debug build, or if you set MALLOC_PERTURB_ on Linux, which writes a value into a freed buffe