Fixes from Alan Dayton (Many thanks!)

[agcapps]

Summary

• This PR is a bugfix from @adayton1
• It does the following:
  • Changes a loop in clip_impl.cpp to use a const ref to objects in a collection rather than make a copy each time through the loop
  • Fixes User code on BlueOS machine reports ptxas error when including IntersectionShaper.h #1156 as suggested by @bmhan12 , by explicitly initializing Point values in object member arrays.

[adayton1]

LGTM

[rhornung67]

Thank you @adayton1 and @agcapps

[kennyweiss]

Looks like there were some failures w/ the cuda pro-e intersection tests w/ our lassen-clang_10_0_1_cuda and lassen-xl_16_1_1_cuda builds. E.g.:

314: [INFO] Load baseline .../axom/axom/data/quest/regression/quest_intersection_shaper/cuda/proeCase2.yaml 
314: [INFO] Load baseline .../axom/axom/data/quest/regression/quest_intersection_shaper/proeCase2.yaml 
314: [INFO] Comparing to baseline  
314: 
314: maxdiff: 
314:   shape_vol_frac_shape0: 0.142101284958428
314: 
314: .../axom/axom/src/axom/quest/tests/quest_intersection_shaper.cpp:399: Failure
314: Expected equality of these values:
314:   success
314:     Which is: false
314:   true
314: 
314: [  FAILED  ] IntersectionShaperTest.proeCase_cuda (476 ms)

[bmhan12]

The cuda test case passes when I revert this default member initalizer change. I am not sure why this causes problem on device...

[agcapps]

!!! Well, thank you for checking on that, Brian. That's very odd.

[kennyweiss]

Great catch @bmhan12 -- looks like uninitialized memory

[kennyweiss]

Thanks @adayton1, @agcapps and @bmhan12 !

[white238]

@agcapps is this ready to be merged after pipelines pass?

[agcapps]

@agcapps is this ready to be merged after pipelines pass?

Yes, it is.

[agcapps]

@bmhan12 , any further comment on this MR?

[bmhan12]

@bmhan12 , any further comment on this MR?

Looks good to me!