Adds openmp variant to Axom's local umpire spack package #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows disabling openmp for compilers that do not support it (e.g. the built-in clang on macos)
kennyweiss
added
TPL
kennyweiss
requested review from
gzagaris,
cyrush,
rhornung67,
MarkoSterbentz and
corbett5
gzagaris
approved these changes
May 30, 2019
gzagaris
approved these changes
May 30, 2019
|
Just FYI, Umpire no longer enable OpenMP by default soon: LLNL/Umpire#110 |
white238
approved these changes
May 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like I merged my previous macos uberenv PR (#48) too soon...
This PR allows disabling openmp in our local umpire spack package for compilers that do not support it (e.g. the built-in clang on macos). Umpire enables openmp by default, so we need to be able to explicitly disable it.
After this PR, I was able to configure uberenv with the default compiler using the following spec
Notes:
Noneand my spec also disabled mpi, e.g.--spec=%clang~openmp~mpi^conduit@master