add __host__ __device__ to defaulted hip constructors #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cuda model requires you not to have host/device notations on defaulted constructors. Apparently hip requires them to generate the constructors on the device. This commit adds a new macro so we can get host/device only for HIP, and uses it to annotate defaulted constructors on tuple_helper.
davidbeckingsale
approved these changes
Jan 14, 2020
|
@trws FYI, this breaks the RAJA build with nvcc. |
|
I can't explain why it appeared to work on nvcc last night, but I had the macro undefined in one case, this version appears to have fixed it. Sorry for the false start. |
|
@trws no worries. I'm testing the build now. Thanks for the quick response. |
rhornung67
approved these changes
Jan 14, 2020
There was a problem hiding this comment.
@trws RAJA builds with this now (I tested 2 versions of nvcc X 3 different host compilers -- just to be paranoid). Thanks!
|
Excellent, thanks for that @rhornung67. I'll merge and we can update raja to this version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cuda model requires you not to have host/device notations on
defaulted constructors. Apparently hip requires them to generate the
constructors on the device. This commit adds a new macro so we can get
host/device only for HIP, and uses it to annotate defaulted constructors
on tuple_helper.