Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the FindMPI command so that it includes both the C and CXX #746

Merged
merged 1 commit into from
Apr 19, 2021
Merged

Fix the FindMPI command so that it includes both the C and CXX #746

merged 1 commit into from
Apr 19, 2021

Conversation

bvanessen
Copy link
Contributor

compiler and linker components.

@cyrush
Copy link
Member

cyrush commented Apr 19, 2021

thanks @bvanessen!

@cyrush
Copy link
Member

cyrush commented Apr 19, 2021

(I will merge pending ci)

@bvanessen
Copy link
Contributor Author

Really we should thank @benson31, he was the one who found it for me.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.326% when pulling 128fa32 on bvanessen:bugfix_cmake_find_mpi into 1b012af on LLNL:develop.

@cyrush cyrush merged commit a36239e into LLNL:develop Apr 19, 2021
@cyrush
Copy link
Member

cyrush commented Apr 19, 2021

thanks @benson31! Just swapped to new use of FindMPI on Friday, thanks for helping us iron this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyrush cyrush cyrush approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bvanessen @cyrush @coveralls