Error when rel is called before match in base Query Language #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilumsden
added
area-query-lang
ilumsden
force-pushed
the
base_ql_err_fix
branch
2 times, most recently
from
c8a61bc
to
e3df7a9
Compare
ilumsden
force-pushed
the
base_ql_err_fix
branch
from
e3df7a9
to
d1e3093
Compare
slabasan
approved these changes
Jun 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the base Query Language, the
matchfunction should always be called to start a query. As a result, it should be expected thatrelwould raise an error if it is called beforematch. However, as discovered by @vanessalama09, therelfunction currently does not raise any error in this situation.So, this PR adds that error raising to
QueryMatcher.rel. It also adds a unit test to confirm that anInvalidQueryPatherror occurs whenrelis called beforematch.