Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing fixed variables/NLP preprocessing [on device] #94

Closed
cnpetra opened this issue Oct 9, 2020 · 2 comments
Closed

removing fixed variables/NLP preprocessing [on device] #94

cnpetra opened this issue Oct 9, 2020 · 2 comments
Assignees

Comments

@cnpetra
Copy link
Collaborator

cnpetra commented Oct 9, 2020

parts of the code NLP preprocessing code need to be revisited since they are "wired" to work only on CPU. Need to either use generic hiopVector kernels or port these parts using Raja. This is especially pervasive in fixed variables removal.

@pelesh

@pelesh
Copy link
Collaborator

pelesh commented Dec 11, 2020

@cnpetra, in #153 I set in hiopOptions::ensureConsistence() to replace "remove" with "relax" option for fixed variables whenever GPU mode is enabled. This may be sufficient to address this issue at least for the time being. Removing fixed variables on GPU device would require more refactoring.

@pelesh pelesh self-assigned this Dec 29, 2020
@cnpetra
Copy link
Collaborator Author

cnpetra commented Jan 14, 2021

closing this since it is partially solved and not of relevance for device computations.

@cnpetra cnpetra closed this as completed Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants