gLaSDI update #126
Closed
gLaSDI update #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaolong7
requested review from
kevinhkhuynh,
dylan-copeland,
chldkdtn,
friesb and
siuwuncheung
|
@dylan-copeland @siuwuncheung @kevinhkhuynh where are we with this PR? Do we have enough review for this PR? |
|
@xiaolong7 Is this PR still in a ready-for-review state, given the recent changes? |
Yes, it is ready for review. |
| # plt.savefig(f"./1Dburger_physical_dynamics.png",bbox_inches='tight') | ||
|
|
||
|
|
||
| # In[ ]: |
There was a problem hiding this comment.
Jupyter Notebook artifacts like these can be removed.
|
@xiaolong7 I am going to close this PR because we have gLaSDI repo in a separate repo. Is it okay? |
|
Fine with me!
…On Tue, May 2, 2023, 9:10 PM Youngsoo Choi ***@***.***> wrote:
@xiaolong7 <https://github.com/xiaolong7> I am going to close this PR
because we have gLaSDI repo in a separate repo. Is it okay?
—
Reply to this email directly, view it on GitHub
<#126 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACPYY6UTEFLKPLIAULCX6G3XEHLCNANCNFSM5ZQ6PGQA>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
|
Closing this PR because we have public gLaSDI repo at https://github.com/LLNL/gLaSDI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converted notebook to Python scripts
Updated README
Corrected typos in src/error_utils.py