Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/koning/maestro git req #42

Merged
merged 3 commits into from
Dec 5, 2019

Conversation

koning
Copy link
Member

@koning koning commented Dec 5, 2019

Fix the git version of meastrowf

@koning koning requested review from ben-bay and lucpeterson and removed request for ben-bay December 5, 2019 17:48
Copy link
Contributor

@ben-bay ben-bay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this syntax work because of special logic in our setup.py?

@koning koning requested a review from ben-bay December 5, 2019 17:48
@koning
Copy link
Member Author

koning commented Dec 5, 2019

My understanding is this is a difference between installing with pip and doing python setup.py install.

@ben-bay
Copy link
Contributor

ben-bay commented Dec 5, 2019

No way to be sure this works until we deploy it, I guess.

@koning
Copy link
Member Author

koning commented Dec 5, 2019

You can create a sdist:
python setup.py sdist
then pip install from the tarball
pip install dist/merlin-1.0.5.tar.gz

@ben-bay ben-bay merged commit 5453255 into LLNL:master Dec 5, 2019
@koning koning deleted the feature/koning/maestro_git_req branch December 5, 2019 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants