Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes for issue #29 #33

Merged
merged 2 commits into from
Apr 26, 2022
Merged

fixes for issue #29 #33

merged 2 commits into from
Apr 26, 2022

Conversation

vsoch
Copy link
Collaborator

@vsoch vsoch commented Apr 26, 2022

This will add some bug fixes and feature requests! namely we:

  1. support search of the name in the search box. This was already added but a bug was preventing it from working. Note that while we do not support "full search" since we do use all words from the repository metadata as tags, this is very close to that.
  2. We now have projects tagged with languages and stars, and the projects can be sorted by stars.
  3. various typos and rendering issues fixed.

Merging here will close #29

Signed-off-by: vsoch vsoch@users.noreply.github.com

This will add some bug fixes and feature requests! namely we:
1. support search of the name in the search box. This was already added but a bug was preventing it from working. Note that while we do not support "full search" since we do use all words from the repository metadata as tags, this is very close to that.
2. We now have projects tagged with languages and stars, and the projects can be sorted by stars.
3. various typos and rendering issues fixed.

Signed-off-by: vsoch <vsoch@users.noreply.github.com>
@vsoch
Copy link
Collaborator Author

vsoch commented Apr 26, 2022

@tzanio here is the preview: https://output.circle-artifacts.com/output/job/119ac725-1e43-4be8-b259-12d67f251803/artifacts/0/radiuss/projects/index.html

And fixes / notes are above. Would you care to review? Please let me know if you have questions or want to discuss any details!

@vsoch vsoch mentioned this pull request Apr 26, 2022
Copy link
Member

@tzanio tzanio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for the quick fix @vsoch. 👍

From the displayed properties, another option is to sort by Language (not sure if we want that)

@vsoch
Copy link
Collaborator Author

vsoch commented Apr 26, 2022

From the displayed properties, another option is to sort by Language (not sure if we want that)

Just alphabetically? Sure I can try to add that. Let's see how JavaScript does sorting strings... 😆

Give me a few minutes to try it out!

Signed-off-by: vsoch <vsoch@users.noreply.github.com>
@vsoch
Copy link
Collaborator Author

vsoch commented Apr 26, 2022

Sort by language is added: 85815bf
New preview: https://output.circle-artifacts.com/output/job/d3eb7e8c-f442-4bd3-b2a9-a905067bbc34/artifacts/0/radiuss/projects/index.html

Note that languages are added as search terms, so if someone wanted to quickly see a language they can type it in the box. It's kind of funny all of the projects are C/C++ and then a few scattered Python. Looks longingly at Go and Rust... 😆

@tzanio
Copy link
Member

tzanio commented Apr 26, 2022

Looks good to me, thanks!

@vsoch vsoch merged commit 92f9648 into main Apr 26, 2022
@vsoch vsoch deleted the fix/issue-20 branch April 26, 2022 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Small suggestions
2 participants