-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python versions of the SCR scripts #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests. Beginning to look at splitting scr_env up. Moving attributes unique to the job launcher environment to a new resourcemanager class. Current path of scr_run follows the srun path. Unique actions will be moved to respective launcher classes so the scr_run script can just use whichever launcher was selected.
fix scr_run with restart_command start to put in $launcher with --use_hosts instead of --exclude_hosts.
…er resource manager is in use, it calls the methods it uses to return a dictionary of hosts keyed with reason for down. Not through all of the scr_list_down_nodes.in files yet.
parsetime.py now returns epoch seconds
shorten resource manager names+move get_runnode_count to scr_env
…anager using pdsh. Differences in commands are highlighted in the varied argument lists they return in their respective resmgr.get_scavenge_pdsh_cmd() methods. Added return values for run/pipe proc when an exception occurs. Added 3 more constants to scr_const that were found in original script.in files.
take develop changes
The scr_test_runtime is performed in the pre_run Tests given as a list, like the Nodetests class. List given by ResourceManager
Added notes for outputs trying both variations of argv
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rewrites the SCR scripts to switch from bash/perl to python. It also implements classes for the job launchers and resource managers. The new scripts are installed in a separate directory from the existing bash/perl scripts so that we can migrate to them over time after sufficient testing.