Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This restores the ability to completely disable fetch by setting
SCR_FETCH=0
. It had instead been tied to fetch bypass when bypass support was added, so that settingSCR_FETCH=0
kept the fetch active but switched to "fetch bypass" mode. Fetch bypass enables one to read files directly from the prefix directory on a restart, rather than have SCR first copy those files to cache.However, a problem arises when restarting an application with a different number of ranks. Even in fetch bypass mode, SCR executes a numbers of checks, including whether the number of ranks listed in the checkpoint matches the number of ranks in the current run. If there is a mismatch, SCR prints a warning and moves on to the next checkpoint. This means SCR would print a bunch of warning messages for apps that actually want to restart with a different number of ranks.
To solve this, the fetch feature can be disabled fully (once again) by setting
SCR_FETCH=0
. For apps that need to restart with a different number of ranks, they can disable fetch to skip those SCR checks and silence the warnings.If one wants to use fetch in bypass mode, a new
SCR_FETCH_BYPASS
param has been added. So now an app can rely on SCR to identify the most recent checkpoint, but tell SCR not to copy those files to cache during restart. Instead,SCR_Route_file
would point to the files directly on the prefix directory: