add --min-nodes to scr_should_exit command #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
--min-nodesoption to thescr_should_exitcommand, which enables a user to specify the required number of nodes to continue running in an allocation in which they may have spare nodes. By default, the command refers to$SCR_MIN_NODESif set. Otherwise, it tries to read the.scr/nodes.scrfile to use the number of nodes from the previous run. Finally, it assumes all nodes in the allocation are required. This new option overrides those other mechanisms.This adds a
--runsoption to thescr_should_exitcommand. This is a temporary option, which simplifies the example job scripts. Ultimately, it would be nice to update the SCR library to support this logic instead. For example, SCR could read the halt file duringSCR_Initand update any "runs remaining" value, similar to how it decrements the checkpoints remaining value. At that point, this temporary option could be dropped.