Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fsisph diffuse mod #103

Merged
merged 24 commits into from
Dec 10, 2021
Merged

Fsisph diffuse mod #103

merged 24 commits into from
Dec 10, 2021

Conversation

jmpearl
Copy link
Collaborator

@jmpearl jmpearl commented Dec 9, 2021

Version of record for the FSI paper.

  1. second order diffusion terms
  2. gave eval derivs its own file to be more constistent w/ other hydros
  3. converted slidesurface to an av like implementation to make it more user-friendly
  4. updated some tests to have FSI

new interfaceFraction metric, and modded eval derivs
…mplementation

some implementation changes in the eval derivs are rolled into this: second order AV and second order vel-grad diffusion
couple of changes to FSISPH Hydro 1) 2nd order reconstuction for diffusion operations, 2) gave evalDerivs its own file consistent w/ spheral style, 3) modified local velocity treatment slightly to get a more stable linear correction -- this is a little more consistent w/ treating damage fronts as material interfaces
fixed a couple bugs and changed some of the implementation to be more consistent with other spheral scripts. The analytic solution got its own file too
@jmpearl jmpearl marked this pull request as ready for review December 10, 2021 02:38
Copy link
Collaborator

@jmikeowen jmikeowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good.

@jmikeowen jmikeowen merged commit dc88a2b into develop Dec 10, 2021
@jmpearl jmpearl deleted the FSISPH-diffuseMod branch December 10, 2021 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants