Fix to just install files under version control for tests directory #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jmikeowen This looks okay to me assuming it runs with the test suite fine from the install location after installing to an empty directory @MishaZakharchanka do you have time to give this a go? |
there's a version of that one generated by the make system.
|
Added logic to avoid copying the tests source directory version of runCXXTests.ats, since that's a special case of the build system generating the version we want to use. |
mdavis36
approved these changes
Dec 14, 2021
MishaZakharchanka
approved these changes
Dec 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bugfix so that the install stage for tests only copies files under version control, rather than scraping everything from the tests source directory.