Bugfix/compiler warnings #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unused parameters warnings/errors (it's the API after all, what errors are we trying to catch?), so excluded those. May be controversial...
mdavis36
requested changes
Jan 31, 2022
There was a problem hiding this comment.
Just a comment and a question below. Might not be for this PR but one thing I'd like to do soon is have a separate Compilers file in our cmake system I started this is #59 but it would be nice to have that consolidated somewhere else outside of our main Setup file.
MishaZakharchanka
approved these changes
Jan 31, 2022
mdavis36
approved these changes
Jan 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaned up some more compiler warnings (things pointed out by gcc 8.x).
Also adding a CMake option to treat warnings as errors, currently defaults to off.